feat(csharp): Add csharp interop#37
Conversation
lidavidm
left a comment
There was a problem hiding this comment.
For files ported from the Apache repo, we need to keep the original license header and add the attribution text (same as for other files)
I kept going through the pre-commit check until it didn't fail anymore. I would get details like: and that all clears now. Is there something else I need to do? |
|
I think instead of taking out the 'this file has been modified' part instead we should list the files in |
|
(I should update the check to make that clear) |
|
Well, technically speaking, the .cs files have all had their namespace changed, so that is a change. The csharp/src/Interop/Build-SnowflakeDriver.ps1 file is different, and various others to match the namespace. Very few actually copied over directly, but I just followed what was in the pre-commit. Do you want me to make the correct updates then add the "unchanged" ones to .rat-apache? |
|
If they were copied then modified, they should have the "modified" header. If they were written for this PR, then they can have the regular header. |
|
yes.. I think it should be good now. |
| # Copyright (c) 2025 ADBC Drivers Contributors | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
I think this needs the 'modified' bit in the header
| Copyright (c) 2025 ADBC Drivers Contributors | ||
|
|
||
| Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Same here (I guess I need to make the check look for "Licensed to the Apache Software Foundation...")
|
|
||
| -- Copyright (c) 2025 ADBC Drivers Contributors | ||
| -- | ||
| -- Licensed to the Apache Software Foundation (ASF) under one |
| <!-- | ||
|
|
||
| Copyright (c) 2025 ADBC Drivers Contributors | ||
|
|
||
| Licensed to the Apache Software Foundation (ASF) under one |
|
|
||
| -- Copyright (c) 2025 ADBC Drivers Contributors | ||
| -- | ||
| -- Licensed to the Apache Software Foundation (ASF) under one |
|
FYI @davidhcoe it seems your Git has no email configured - is this intentional? |
This account has been used for personal, professional and educational projects, each with separate email accounts, so I just didn't assign one. |
What's Changed
Ports over the current state of https://github.com/apache/arrow-adbc/tree/main/csharp/src/Drivers/Interop/Snowflake, changed the namespace, updated headers and build scripts.